Notes for pkg check
Several notes about this package :
-
devtools::check()return a note about usage of:::, not critical during development. -
strava_activitiesshould be replaced with a data for this package. Ideally in ainst/create_data.Rscript that useusethis::use_data()so it can be updated later. -
stopifnot(e %in% v)for arguments can be replaced with a match.arg() where all possibilities are placed in argument definition, the first one being default. Example :
#' @param Sport type, multiple choices available, default is "all".
foo <- function(sport = c("all", "run")){
match.arg(sport)
print(sport)
}
-
get_strava()can use@inheritParams create_strava, to simplify documentation😁
Everything else is really clean, I'll start to play with it and test if forgemia allows to run dowloads on tanguy with CI/CD tools.